WB-1635.fix - Fix border issue on Button.secondary #2124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4d6897b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
GeraldRequired Reviewers
Don't want to be involved in this pull request? Comment |
|
Size Change: +13 B (0%) Total Size: 92.7 kB
ℹ️ View Unchanged
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2124 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 243 243
Lines 28247 28250 +3
Branches 2466 2420 -46
=======================================
+ Hits 27420 27423 +3
Misses 827 827
Continue to review full report in Codecov by Sentry.
|
npm Snapshot: Published🎉 Good news!! We've packaged up the latest commit from this PR (dce29ba) and published all packages with changesets to npm. You can install the packages in webapp by running: ./services/static/dev/tools/deploy_wonder_blocks.js --tag="PR2124"Packages can also be installed manually by running: yarn add @khanacademy/wonder-blocks-<package-name>@PR2124 |
A new build was pushed to Chromatic! 🚀https://5e1bf4b385e3fb0020b7073c-cfrdbjdkjg.chromatic.com/ Chromatic results:
|
jeresig
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In #2112, I introduced a new
labelStyleprop and refactored the styles for thesecondary button. However, I missed a case where the border was not being
applied correctly, causing the button from being cut off in certain scenarios.
This PR fixes that issue by including the
borderin the resting/default state,so the button is always rendered with a border (including that as part of
the box model).
NOTE: The issue was noticed while trying to integrate the changes in webapp.
Issue: WB-1635
Test plan:
Verify that the secondary button is rendered correctly in all scenarios. This
means that now secondary buttons will always have a border in the resting state.