Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WB-1636: Add describedBy prop to announce the popover dialog contents to screen readers. #2110

Closed
wants to merge 3 commits into from

Merge remote-tracking branch 'origin/main' into popover-sr

9306f8a
Select commit
Loading
Failed to load commit list.
Closed

WB-1636: Add describedBy prop to announce the popover dialog contents to screen readers. #2110

Merge remote-tracking branch 'origin/main' into popover-sr
9306f8a
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Nov 16, 2023 in 1s

97.07% (+0.00%) compared to 6b8bf8d

View this Pull Request on Codecov

97.07% (+0.00%) compared to 6b8bf8d

Details

Codecov Report

Merging #2110 (9306f8a) into main (6b8bf8d) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2110   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files         243      243           
  Lines       28245    28286   +41     
  Branches     2466     2420   -46     
=======================================
+ Hits        27418    27459   +41     
  Misses        827      827           
Files Coverage Δ
...-blocks-popover/src/components/popover-content.tsx 99.38% <100.00%> (+0.03%) ⬆️
...r-blocks-popover/src/components/popover-dialog.tsx 99.32% <100.00%> (+<0.01%) ⬆️
...s/wonder-blocks-popover/src/components/popover.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b8bf8d...9306f8a. Read the comment docs.