[SR] Quadratic - add screen reader support for Quadratic interactive graph #2136
+719
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [SRUX doc](https://khanacademy.atlassian.net/wiki/spaces/LC/pages/3460366348/Linear) still needs a label for the grab handle, but I tried my best in the meantime. - Add a label and describedby for the grab handle. - Add aria-live states for the different interactive elements so they don't override each other. Issue: https://khanacademy.atlassian.net/browse/LEMS-1726 Test plan: `yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/linear.test.tsx` Storybook - http://localhost:6006/iframe.html?id=perseuseditor-widgets-interactive-graph--interactive-graph-linear&viewMode=story - Try all the different slopes and intercepts - Move different elements and confirm that the updated aria-label is what is read out, and none of the other elements override the currently focused one.
…inear System interactive graph
…atic interactive graph
nishasy
commented
Jan 22, 2025
There was a problem hiding this comment.
Renamed to quadratic.test.tsx since it has React components now.
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (bd82b4c) and published it to npm. You Example: yarn add @khanacademy/perseus@PR2136If you are working in Khan Academy's webapp, you can run: ./dev/tools/bump_perseus_version.sh -t PR2136 |
|
Size Change: +1.78 kB (+0.12%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
SonicScrewdriver
approved these changes
Jan 22, 2025
| ${"up, quadrant vertex, 2 intercepts"} | ${[[-6, 5], [-1, -1], [4, 5]]} | ${"upward"} | ${"in quadrant 3"} | ${[1.041, -3.041]} | ${-0.76} | ||
| ${"sloped line, no vertex, 1 intercept"} | ${[[-5, -5], [0, 0], [5, 5]]} | ${undefined} | ${undefined} | ${[0]} | ${0} | ||
| ${"horizontal line, no vertex, no intercept"} | ${[[-5, 1], [0, 1], [5, 1]]} | ${undefined} | ${undefined} | ${[]} | ${1} | ||
| `( |
There was a problem hiding this comment.
This is beautiful. :)
catandthemachines
approved these changes
Jan 23, 2025
| @@ -17,10 +27,14 @@ import type {QuadraticCoefficient, QuadraticCoords} from "@khanacademy/kmath"; | |||
| export function renderQuadraticGraph( | |||
| state: QuadraticGraphState, | |||
| dispatch: Dispatch, | |||
| i18n: I18nContextType, | |||
There was a problem hiding this comment.
Yay!! Thank you for fixing this. 🥰
| strings, | ||
| locale, | ||
| ); | ||
| // Vertex might not exist if the quadratic graph is a line |
There was a problem hiding this comment.
Nice catch with this.
| ): string { | ||
| const strings = describeQuadraticGraph(state, i18n); | ||
| // This particular string will never be undefined. | ||
| return strings.srQuadraticInteractiveElements || ""; |
There was a problem hiding this comment.
If this string will always be defined, could you update the describeQuadraticGraph to return type Record<string, string>, not Record<string, string | undefined>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add the aria label and descriptions for the full graph and interactive elements
in the Quadratic graph, based on the SRUX doc.
NOTE: The SRUX doc doesn't yet cover some edge cases, so I handled those to the
best of my ability.
Issue: https://khanacademy.atlassian.net/browse/LEMS-2486
Test plan:
yarn jest packages/perseus/src/widgets/interactive-graphs/graphs/quadratic.test.tsxStorybook