Add job to validate exercise IDs in assessments #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csilvers
approved these changes
Jan 23, 2025
| import org.khanacademy.Setup; | ||
|
|
||
|
|
||
| new Setup(steps).apply(); |
There was a problem hiding this comment.
You want to run this as a cronjob, right? So you need to add a cron step here. Though maybe you're planning to do that later once you confirm this works? I'd probably do it from the beginning, tbh. It's pretty straightforward what you're doing and all the work is in the go binary, so this won't take a lot of iterating.
There was a problem hiding this comment.
Ah okay, I thought I was supposed to configure that in Jenkins! Will add it now
| def runScript() { | ||
| withTimeout('1h') { | ||
| dir("webapp") { | ||
| sh("go run services/assessments/cmd/check_assessments_exercise_ids/main.go"); |
There was a problem hiding this comment.
This is fine, and certainly very common in our jenkins code, but I think it's a bit safer to do exec:
exec(["go", "run", "services/..."]);
It's totally up to you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Our interim assessments contain exercise IDs that we use to look up content, and we need to be alerted if any of those IDs become invalid. This job checks for invalid exercise IDs and alerts us if it finds any.
Issue: INFRA-10509
Test plan:
Verify that the job ran correctly in Jenkins. Note that the failure is intended - I made a test configuration invalid to ensure the alert would work.