No longer create cloud-run tags on every deploy. #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we are routing to cloud-run in fastly (and Go), we no longer need to create tags on every deploy to help us with the routing. Huzzah! This needs to wait to deploy until we are fully off of VCL and not going back. Since we did not backport the route-to-cloud-run logic to VCL. Issue: https://khanacademy.atlassian.net/browse/INFRA-10502 Test plan: I ran `groovy jobs/build-webapp.groovy` without any new errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Now that we are routing to cloud-run in fastly (and Go), we no longer
need to create tags on every deploy to help us with the routing. Huzzah!
This needs to wait to deploy until we are fully off of VCL and not
going back. Since we did not backport the route-to-cloud-run logic to
VCL.
Issue: https://khanacademy.atlassian.net/browse/INFRA-10502
Test plan:
I ran
groovy jobs/build-webapp.groovywithout any new errors.