Skip to content

Commit

Permalink
[🔥AUDIT🔥] Target node 12 so we don't break folks that haven't upgrade…
Browse files Browse the repository at this point in the history
…d yet (#29)

🖍 _This is an audit!_ 🖍

## Summary:
oops!
https://khanacademy.slack.com/archives/C02NMB1R5/p1650646528384399

Issue: XXX-XXXX

## Test plan:
run `npm run build`, and switch to node 12 w/ nvm or whatever you've got. `node ./dist/cli/run.js` should work, instead of crashing with a syntax error!
Switch back to node 16 and ensure that it also runs fine under 16.

Author: jaredly

Auditors: somewhatabstract

Required Reviewers:

Approved By:

Checks: ✅ Lint & Test (ubuntu-latest, 16.x)

Pull Request URL: #29
  • Loading branch information
jaredly authored Apr 22, 2022
1 parent 6a0ac88 commit 31dd235
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .babelrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"presets": [
"@babel/preset-flow",
["@babel/preset-env", { "targets": { "node": "16" } }]
["@babel/preset-env", { "targets": { "node": "12" } }]
]
}
5 changes: 5 additions & 0 deletions .changeset/blue-plants-develop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@khanacademy/graphql-flow': patch
---

Compile for node 12 instead of 16

0 comments on commit 31dd235

Please sign in to comment.