Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped sync timer to 5500 #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bumped sync timer to 5500 #61

wants to merge 1 commit into from

Conversation

0x4f53
Copy link
Member

@0x4f53 0x4f53 commented Feb 8, 2023

♻️ Current situation

The network call timer thread executed too frequently, causing Volley to suffer from a memory leak from inconclusive requests.

💡 Proposed solution

Increase the timer interval to 5500ms.

📷 Screenshots

NA

📚 Release Notes

  • Changed the timer interval to 5500ms.

📝 Testing

  • Start the Keyspace app, make sure your vault has entries.
  • Keep the app open for 15 minutes and check if the app is still up and running in the foreground.
  • Tell me if it crashes or not in the comments.

@rohan-chaturvedi rohan-chaturvedi self-requested a review February 8, 2023 08:09
@rohan-chaturvedi
Copy link
Member

@4f77616973 It seems to work fine up to 15 min. I had a crash between 20-25 min. Trying to recreate it again to get a more accurate time.

@0x4f53
Copy link
Member Author

0x4f53 commented Feb 10, 2023

Any updates on this?

@rohan-chaturvedi
Copy link
Member

Any updates on this?

I'm still getting a crash around the 20 min mark. If 15 min is an acceptable window then we can go ahead with this, but it doesn't seem to be addressing the root cause of the crash. Also weirdly, I don't get the crash log dialog when it crashes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants