Support PHP 8.4 #191
Merged
Support PHP 8.4 #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @andrewnicols for this PR. I think that we can add a default value to Maybe something like |
|
Cheers, I've set a default value in the constructor of |
|
There are some errors with |
* Add tests in GitHub Action * Explicitly declare nullable parameters as nullable
Many of the dependencies were outdated and did not support the full range of PHP versions supported by this project at both extremes, specifically the lowest optioned versions of the following dependencies did not support PHP 8.4: - guzzlehttp/guzzle - guzzlehttp/promises - guzzlehttp/psr7 - phpunit/phpunit - symfony/phpunit-bridge Meanwhile the highest possible version of each of the above already supported PHP 8.1 and above, including PHP 8.4.
|
Thanks @Kevinrob , I saw these the other day but didn't get a chance to trouble-shoot. I ended up having to reduce some alternate versions, but most of the existing lowest options were unsupported, and all of the highest version options were fully supported.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.4 is now in release candidate and due for release in about 6 weeks. Features are now sealed.
This pull request:
Note: There is still a warning in relation to the
GreedyCacheStrategybecause the second argument ($defaultTtl) is required, but the first argument is optional. I'm not sure how you wish to resolve this so I'll defer to a separate issue. Options are to either stop the first argument (CacheStorageInterface $cache) from having a default value (but still allowing nullability), or to provide a default of the default ttl.