Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing PyHIP with new official python wrapper of ROCm HIP #285

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

MiloLurati
Copy link
Contributor

This pull request replaces PyHIP with the new official python wrapper of rocm HIP and enables passing DeviceArray types (a HIP Python type) as an argument.

@benvanwerkhoven
Copy link
Collaborator

Hi @MiloLurati,

Thanks for the pull request! I think it's ready, or would you like to leave it in draft for now? The main reason to wait is perhaps that hip-python is not indexed in PyPI yet.

@MiloLurati
Copy link
Contributor Author

Hi @benvanwerkhoven ,

Yes, I can un-draft it. I've been tuning quite a lot lately with Kernel Tuner and HIP Python and have also been using the DeviceArray wrapper to allocate device memory in the Python script. I haven't encountered any problems so far. If it's okay with you, we could merge these changes.

@MiloLurati MiloLurati marked this pull request as ready for review January 16, 2025 13:58
@stijnh
Copy link
Member

stijnh commented Jan 16, 2025

I've also add support for half/bfloat16 precision to the HIP backend. I will wait with merging my changes until after the new HIP backend is merged so that I can rebase my changes to use PyHIP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants