공통 컴포넌트: Header #35
Merged
공통 컴포넌트: Header #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seoye0ng
added
✨ Feature
Closed
4 tasks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bottlewook
requested changes
Jan 5, 2024
| li.right { | ||
| margin-left: auto; | ||
|
|
||
| a { |
There was a problem hiding this comment.
이거 reset css에 있는 내용이라 지워주셔도 돼요!
| @@ -0,0 +1,28 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Suggested change
| import React from 'react'; |
지워주세요~
| }:HeaderProps) { | ||
| // TODO: login 상태 가져오기 | ||
| return ( | ||
| <nav className={`${styles.nav} ${isTransparent ? styles.transparent : ''}`}> |
There was a problem hiding this comment.
classNames 사용해주세요~
const cx = classNames.bind(styles)
Suggested change
| <nav className={`${styles.nav} ${isTransparent ? styles.transparent : ''}`}> | |
| <nav className={cx('nav', {'transparent': isTransparent}}> |
| // TODO: login 상태 가져오기 | ||
| return ( | ||
| <nav className={`${styles.nav} ${isTransparent ? styles.transparent : ''}`}> | ||
| <ul className={styles.container}> |
There was a problem hiding this comment.
Suggested change
| <ul className={styles.container}> | |
| <ul className={cx('container')}> |
| {!displayLogo && <LeftIcon className={styles.left} />} | ||
| {displayLogo && <CenterIcon className={styles.logo} />} | ||
| <RightIcon | ||
| className={styles.right} |
There was a problem hiding this comment.
Suggested change
| className={styles.right} | |
| className={cx('right')} |
| ul { | ||
| margin: 0; | ||
| padding-left: 0; | ||
| list-style: none; |
There was a problem hiding this comment.
Suggested change
| list-style: none; | |
| list-style: none; |
| } | ||
|
|
||
| ul { | ||
| margin: 0; |
There was a problem hiding this comment.
이것도 빼주세요
Suggested change
| margin: 0; | |
| margin: 0; |
| @@ -0,0 +1,21 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Suggested change
| import React from 'react'; |
| @@ -0,0 +1,16 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
Suggested change
| import React from 'react'; |
| width: 100%; | ||
| height: 48px; | ||
| padding: 0 24px; | ||
| background-color: var(--white); |
There was a problem hiding this comment.
이거 sass 지원하는 변수 형태인 $white로 사용할 수 있도록 설정을 바꿔볼까요?
bottlewook
reviewed
Jan 5, 2024
| className: string; | ||
| } | ||
|
|
||
| function CenterIcon({ className }:CenterIconProps) { |
There was a problem hiding this comment.
props가 1개 일 떄는 아래 형식으로 작성하는 건 어떠신가요
Suggested change
| function CenterIcon({ className }:CenterIconProps) { | |
| function CenterIcon({ className }:{className: string}) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해당 사항 (중복 선택)
설명
Key Changes
How it Works
To Reviewers