ci: update internal testnet reset workflow #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirtleshell
requested review from
rhuairahrighairidh,
karzak,
drklee3,
nddeluca,
DracoLi,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
|
🚀 |
nddeluca
reviewed
Oct 17, 2024
| on: | ||
| workflow_run: | ||
| workflows: [Continuous Integration (Kava Master)] | ||
| types: | ||
| - completed | ||
| workflow_dispatch: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
It's great to see re-use of the workflow jobs instead of duplicating them
pirtleshell
commented
Oct 17, 2024
Comment on lines
+32
to
+34
| if: | | ||
| github.event_name == 'workflow_dispatch' || | ||
| (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success' && needs.changed_files.outputs.changedInternalTestnetConfig == 'true') |
There was a problem hiding this comment.
this is the logic for whether or not to actually reset the network.
it amounts to:
- reset network if we are manually dispatching the flow. the manual dispatch is a specific choice. if i hit the reset network button, the network should reset regardless of what the content of the HEAD commit is.
- when a commit to master passes the test CI, reset the network if the files in
ci/kava-internal-testnethave changed. only commits that include changes toKAVA.VERSIONor the genesis file trigger an automated reset
pirtleshell
added a commit
that referenced
this pull request
Oct 25, 2024
* ci: update internal testnet reset workflow * on merge to master, only redeploy when files changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates CD pipeline for internal testnet, now on newer infra. The action uses the same workflows as the protonet flow, but with different variables.
Confirmed the reset + seeding of network works by running the workflow locally.
Additionally, removed all workflows and scripts that are no longer used.
The workflow is triggered in either of these cases:
ci/kava-internal-testnethave changednote the above differs from protonet, which deploys on any commit to master. even with
KAVA.VERSIONpinned tomaster, the network will not redeploy on new commits because the files inci/kava-internal-testnetwill not change. if the commit is updated or the genesis file changes, the network will be reset & deployed. otherwise, the network will only be reset if the workflow is manually dispatched.