chore(ci): update internal testnet genesis and seed to support committee voting #2008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DracoLi
requested review from
rhuairahrighairidh,
karzak,
pirtleshell,
drklee3,
nddeluca,
evgeniy-scherbina,
sesheffield,
boodyvo and
lbayas
as code owners
nddeluca
reviewed
Aug 16, 2024
nddeluca
approved these changes
Aug 16, 2024
pirtleshell
reviewed
Aug 16, 2024
| @@ -2172,7 +2172,7 @@ | |||
| "max_deposit_period": "172800s" | |||
| }, | |||
| "voting_params": { | |||
| "voting_period": "600s" | |||
| "voting_period": "604800s" | |||
There was a problem hiding this comment.
is this being updated on purpose? it's more useful for our internal testnets to use short voting periods so that we can submit & pass test proposals (waiting 10min vs waiting 1 week)
There was a problem hiding this comment.
yeah, this was requested so the proposal is up longer for testing on webapp. I suggest we increase it for now and can revert it back later. I'd also like to keep a shorter time period for faster proposals.
pirtleshell
pushed a commit
that referenced
this pull request
Oct 25, 2024
…tee voting (#2008) * chore(ci): update internal testnet genesis and seed to support committee voting * chore(ci): update gov proposal voting period to 7 days * chore: use auto gas calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
eip712_allowed_msgsto allow for committee voting.