feat: Re-apply patches onto v0.47.15 #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6f151ac)
(cherry picked from commit 3833525)
includes patches for: * fixed initial version of added KVStores * expose DeleteVersionsFrom on MutableTree patches are published here: https://github.com/Kava-Labs/kava-patches/tree/19bf1a78805a33fe7a27044f2b03dc3ce1d90392/iavl-v1.2
* add --unsafe-remove-modules flag to Rollback cmd * adds public DeleteKVStore method on root multistore * rollback command accepts list of store keys names to forcibly delete this is useful for rolling back an upgrade that adds modules. rollbacks are performed by loading & committing the previous version. without this new functionality, the rollback will fail because no store version will exist for modules added during the upgrade. to properly rollback the state, pass in a list of the added module names and they will be completely removed before the rollback of pre-existing modules takes place: ``` chain rollback --unsafe-remove-modules mynewmodule,othernewmodule ``` * add DeleteVersionsFrom to Tree like DeleteVersionsTo, but deletes the given version & upwards * write deletion of current & future versions * rename DeleteKVStore -> DeleteLatestVersion * remove unnecessary deleteKVStore call the DeleteVersionsFrom on the unwrapped KVStore should be sufficient
* removes incompatible CI workflows * enables CI testing on kava release branches
additionally, updates the setup-go github action from v3 -> v5
* remove sonar cloud ci * remove unused sim tests & fix nightly sim continue running a nightly sim but comment out the unused slack notification channels
the test coverage it provides is covered by the nightly sims test & there isn't frequent enough code changes to this repo to warrant 12 runs a day.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+1010
to
+1015
| for k := range rs.storesParams { | ||
| if k.Name() == keyName { | ||
| key = k | ||
| break | ||
| } | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
drklee3
force-pushed
the
dl-v0.47.15-patched
branch
from
b6b2873 to
a254e39
Compare
drklee3
added a commit
to Kava-Labs/kava
that referenced
this pull request
Jan 21, 2025
This uses a TEMPORARY commit hash for testing, from PR Kava-Labs/cosmos-sdk#560 This will be tested first against mainnet to ensure there are no apphash mismatch errors
drklee3
merged commit adafbee
into
kava-v0.47.15-iavl-v1-release-x
17 of 21 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverse method of starting with clean v0.47.15 upstream base, instead of cherry-picking upstream onto our patches. Clearer diffs of only our changes