Spacedock transformer: remove version string -> release_status parsing #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elease status Prior to #4260, the release_status field was purely for user information and did not affect which versions CKAN would index or install. The PR changed that (and we had already removed the release_status from existing netkans). In order to prevent older clients from installing pre-release versions, these versions are now marked with spec_version 1.36. The above PR also added a bit of logic that parsed the version string from mods hosted on spacedock; setting their release_status to "testing" if it has one of the strings "alpha," "beta," "pre." This has led to some trouble, even for older clients. Versions of mods that are hosted on spacedock that used to be installable no longer are (some of these had their last release years ago). Also since non-latest versions don't get re-inflated, this leads to the older ckan clients installing the second-newest version from spacedock even if it's also labeled "beta." This happened to kopernicus expansion continueder, and it's especially unfortunate because the 2nd-newest version has a bug that makes it completely broken (which is what led me to discover this in the first place). HebaruSan also applied the "testing" status to that release, but then this has the effect of making the mod not visible at all to the older ckan client, which is creating new issues of users needing support when they try to install mods that depend on kopernicus expansion.
|
Alternative proposal: what if we made a special flag in the .netkan to opt into this behavior for spacedock? |
HebaruSan
approved these changes
Jan 28, 2025
|
An opt-in flag in the Netkan seems like a great compromise: basically adds prerelease support to spacedock for modders that want it and preserves the old behavior for mods that won’t get new updates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #4260, the release_status field was purely for user information and did not affect which versions CKAN would index or install. The PR changed that (and we had already removed the release_status from existing netkans). In order to prevent older clients from installing pre-release versions, these versions are now marked with spec_version 1.36.
The above PR also added a bit of logic that parsed the version string from mods hosted on spacedock; setting their release_status to "testing" if it has one of the strings "alpha," "beta," "pre."
This led to some trouble, even for older clients. Versions of mods that are hosted on spacedock that used to be installable no longer are (some of these had their last release years ago). Also since non-latest versions don't get re-inflated, this leads to the older ckan clients installing the second-newest version from spacedock even if it's also labeled "beta." This happened to kopernicus expansion continueder, and it's especially unfortunate because the 2nd-newest version has a bug that makes it completely broken (which is what led me to discover this in the first place). HebaruSan also applied the "testing" status to that release, but then this has the effect of making the mod not visible at all to the older ckan client, which is creating new issues of users needing support when they try to install mods that depend on kopernicus expansion.
lengthy discussion here: https://discord.com/channels/601452466017665040/601459946684547095/1333492865220739214