Restore default version support for SpaceDock #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BeyondJool currently has this inflation error:
Cause
There's a 1-MB dummy download with a version of
TEST (do not use)sitting at the top of the list of releases:The inflator is downloading this and discovering that it doesn't contain the mod, even though the "Set as default" button was used on SpaceDock to mark the previous download. This most likely broke when we added the
--releasesand--skip-releasesoptions to Netkan because support for the default release flag was only inSpacedockMod.Latest, which is no longer used because it only returns one version.Changes
Now the default release setting is used to sort the releases from SpaceDock, so it will determine which release gets inflated. If we inflate multiple releases, the others will be checked after the default.