Optimize label searches and handle spaces in names #4270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you make a label with spaces in its name and apply it to some mods, filtering by that label finds no mods.
Reported by Discord user TEMPEST.
Cause
The search syntax uses spaces to separate parts of the search, so
label:Name With Spaces
is changed tolabel:NameWithSpaces
, but the label checking logic wasn't accounting for this.Changes