test: esm variant of integration tests #779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arty-name
approved these changes
Jul 25, 2023
| roots: ['<rootDir>/tests/breakingChanges'], | ||
| }, | ||
| ] | ||
| } |
There was a problem hiding this comment.
Will the project benefit from an .editorconfig file?
There was a problem hiding this comment.
looks like it is not well supported in VSCode, which most of the team uses (https://asp.net-hacker.rocks/2020/01/13/editorconfig.html), but it can't hurt either I assume. I did format it though?
There was a problem hiding this comment.
The post is 3 years old, isn’t it :)
In the full diff GitHub highlights the files without a trailing newline.
Yeah sorry for these. I could have avoided some of the noise from the reordering, but these are files where I had to touch the imports anyway, so I figured I may as well leave them cleaned up... |
rflechtner
added a commit
that referenced
this pull request
Jul 26, 2023
* test: move integration tests to tests directory * test: integration tests on esm * tests: move test utils to tests folder * tests: move jest setup file * tests: use projects instead of group runner * tests: update test coverage setup * tests: fix failing & flaky integration tests * ci: run esm tests in ci
rflechtner
added a commit
that referenced
this pull request
Aug 3, 2023
* test: move integration tests to tests directory * test: integration tests on esm * tests: move test utils to tests folder * tests: move jest setup file * tests: use projects instead of group runner * tests: update test coverage setup * tests: fix failing & flaky integration tests * ci: run esm tests in ci
rflechtner
added a commit
that referenced
this pull request
Aug 3, 2023
* test: move integration tests to tests directory * test: integration tests on esm * tests: move test utils to tests folder * tests: move jest setup file * tests: use projects instead of group runner * tests: update test coverage setup * tests: fix failing & flaky integration tests * ci: run esm tests in ci
rflechtner
added a commit
that referenced
this pull request
Aug 3, 2023
* test: move integration tests to tests directory * test: integration tests on esm * tests: move test utils to tests folder * tests: move jest setup file * tests: use projects instead of group runner * tests: update test coverage setup * tests: fix failing & flaky integration tests * ci: run esm tests in ci
rflechtner
added a commit
that referenced
this pull request
Aug 22, 2023
* refactor!: nest ctype in ICTypeDetails (#766) * refactor: change ctype parameter name to cType where possible * feat: re-export imported types from @kiltprotocol/types (#762) * feat: deprecate CType meta schema draft-01 (#778) * fix: default to log level warn in non-production environments * test: skip expensive delegation node tests * test: esm variant of integration tests (#779) * test: make tests work with new kilt node cli (#796) * chore: update metadata to 1.11.0 * chore(deps): update cbor-web to v9 * chore(deps-dev): bump webpack from 5.70.0 to 5.76.0 (#771) * chore(deps-dev): bump semver-regex from 3.1.3 to 3.1.4 (#775) * chore(deps-dev): bump typedoc to resolve dependency conflict * ci: make latest-develop tests optional and latest mandatory Co-authored-by: Gerawork Aynekulu <[email protected]> Co-authored-by: Raphael Flechtner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes KILTProtocol/ticket#2753
Cleans up testing infrastructure and sets up integration tests to be run against both the cjs and esm variants of the code.
Includes:
testsfolderHow to test:
Tests are run in CI and should complete successfully.
Checklist: