Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workshop to v1 of SDK #330

Merged
merged 19 commits into from
Oct 31, 2024
Merged

Update workshop to v1 of SDK #330

merged 19 commits into from
Oct 31, 2024

Conversation

ChrisChinchilla
Copy link
Contributor

fixes KILTProtocol/ticket#3594

Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla changed the base branch from master to sdk-v1 October 24, 2024 15:03
sdk/02_tutorial/01_welcome.md Outdated Show resolved Hide resolved
sdk/02_tutorial/03_overview.md Outdated Show resolved Hide resolved
sdk/02_tutorial/03_overview.md Outdated Show resolved Hide resolved
sdk/02_tutorial/03_overview.md Outdated Show resolved Hide resolved
sdk/02_tutorial/06_holder/02_create_presentation.md Outdated Show resolved Hide resolved
sdk/02_tutorial/06_holder/index.md Outdated Show resolved Hide resolved
sdk/02_tutorial/07_verification.md Outdated Show resolved Hide resolved
sdk/02_tutorial/07_verification.md Outdated Show resolved Hide resolved
sdk/02_tutorial/07_verification.md Outdated Show resolved Hide resolved
Signed-off-by: Chris Chinchilla <[email protected]>
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some nitpicks remaining

sdk/02_tutorial/05_issuer/03_issue_credential.md Outdated Show resolved Hide resolved
sdk/02_tutorial/06_holder/02_create_presentation.md Outdated Show resolved Hide resolved
sdk/02_tutorial/07_verification.md Outdated Show resolved Hide resolved
sdk/02_tutorial/07_verification.md Outdated Show resolved Hide resolved
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review October 31, 2024 09:44
@ChrisChinchilla
Copy link
Contributor Author

@rflechtner If you're good with it now, let's get this merged into the SDK branch and I will fix the code transclusion now.

Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks!

@ChrisChinchilla ChrisChinchilla merged commit 232c02b into sdk-v1 Oct 31, 2024
0 of 5 checks passed
@ChrisChinchilla ChrisChinchilla deleted the 3594-update-workshop branch October 31, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants