Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for OpenDID #313

Merged
merged 16 commits into from
Jun 13, 2024
Merged

Add Documentation for OpenDID #313

merged 16 commits into from
Jun 13, 2024

Conversation

abdulmth
Copy link
Contributor

No description provided.

abdulmth and others added 2 commits May 30, 2024 12:59
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-313.d3oeht7cvddn19.amplifyapp.com

Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Copy link
Contributor

@abdulmth Made a bunch of changes, take a look!

Copy link
Contributor Author

@abdulmth abdulmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisChinchilla LGTM, thanks for the improvements.

docs/develop/08_opendid/03_opendid_service.md Show resolved Hide resolved
@abdulmth abdulmth requested a review from ntn-x2 June 10, 2024 11:45
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good! I left some comments, feel free to accept some of them and reject others.

docs/develop/08_opendid/01_overview.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/01_overview.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/02_opendid_flow.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/02_opendid_flow.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/02_opendid_flow.md Show resolved Hide resolved
docs/develop/08_opendid/04_integrate_opendid.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/04_integrate_opendid.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/05_demo_project.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/05_demo_project.md Outdated Show resolved Hide resolved
docs/develop/08_opendid/06_advanced.md Outdated Show resolved Hide resolved
@ChrisChinchilla
Copy link
Contributor

@ntn-x2 I have no idea why but I can't reply to the comment directly 🤷

#313 (comment)

What do you mean by "promote to top level"?

Signed-off-by: Chris Chinchilla <[email protected]>
@ntn-x2
Copy link
Member

ntn-x2 commented Jun 12, 2024

@ChrisChinchilla

What do you mean by "promote to top level"?

Indent it once more to the left 😃

@ChrisChinchilla
Copy link
Contributor

ChrisChinchilla commented Jun 12, 2024

@ChrisChinchilla

What do you mean by "promote to top level"?

Indent it once more to the left 😃

@ntn-x2 Sorry, still a bit confused… Indent what to the left?

## Configuration is a heading and the bullet points are all correct levels. I am not clear on what you're refering to… Maybe you could comment on the exact line or make a suggestion inline?

@ntn-x2
Copy link
Member

ntn-x2 commented Jun 13, 2024

Screenshot 2024-06-13 at 08 28 16

@ChrisChinchilla hope this helps. It's a minor thing tho and it won't change the way the text is rendered. So if you still don't understand, feel free to go ahead anyway.

@ChrisChinchilla
Copy link
Contributor

@ntn-x2 I see, however, that indentation is correct.

@abdulmth It's your PR, go wild!

@ChrisChinchilla ChrisChinchilla self-requested a review June 13, 2024 07:23
@abdulmth abdulmth merged commit 66cf879 into master Jun 13, 2024
5 of 6 checks passed
@abdulmth abdulmth deleted the feat/opendid branch June 13, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants