-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Documentation for OpenDID #313
Conversation
Signed-off-by: Chris Chinchilla <[email protected]>
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Signed-off-by: Chris Chinchilla <[email protected]>
@abdulmth Made a bunch of changes, take a look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisChinchilla LGTM, thanks for the improvements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good! I left some comments, feel free to accept some of them and reject others.
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Co-authored-by: Antonio <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
Signed-off-by: Chris Chinchilla <[email protected]>
@ntn-x2 I have no idea why but I can't reply to the comment directly 🤷 What do you mean by "promote to top level"? |
Signed-off-by: Chris Chinchilla <[email protected]>
Indent it once more to the left 😃 |
@ntn-x2 Sorry, still a bit confused… Indent what to the left?
|
@ChrisChinchilla hope this helps. It's a minor thing tho and it won't change the way the text is rendered. So if you still don't understand, feel free to go ahead anyway. |
No description provided.