WIP [#30] - Add a simple text based protocol to the project to display continuous measurement results #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details:
- In order to be able to implement the CMDP or similar
protocols the I_Protocol needed to be reworked so that
it communicates trough callbacks and not simple returns
the diagrams that it processed from a stream
- Renamed the methods in I_Protocol in order to be more consistent
- Updated the MDP with the I_Protocol changes
- Updated the CMDP with the I_Protocol changes
Details:
- Switching to callbacks from using Qt signals to
ensure consistency with the changes in I_Protocol
- Updating the SerialPort class with the I_Connection changes
Details: - Activating the CMDP protocol - Updating the Backend::StoreNetworkDiagrams() so it returns QModelIndexes to the stored diagram - Updating the Backend::StoreFileDiagrams() so it returns QModelIndexes to the stored diagram - Adding the Backend::UpdateNetworkDiagram() - Removing callback typedefs from the NetworkHandler and using the ones in the I_Protocol instead - Updating the NetworkHandler after the I_Connection and I_Protocol changes (callbacks instead of signals)
Details: - Minor update in I_Protocol::ImportFromFile() - Updating the test_protocol_common.h - Updating the MDP unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #30