Add longitudinal position residual #196
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brownd1978
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
This all looks good.
At first I was wondering why you didn't use PointClosestApproach for the residuals when there's a 3-D constraint, but then I realized the errors are too asymmetric for that to work, what you coded is better. I'm thinking we should bundle all the ClosestApproach derivatives (dDdP, dTdP, and now dLdP) into one tensor/struct, but as long as the DOFs are independent it probably doesn't buy much, besides making the interface cleaner. Lets see what this looks like in the Mu2e code, then we can discuss possible consolidations.
|
is more activity planned for this PR? |
|
I'm working on alignment interface which may supersede some of these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.