-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
패스트캠퍼스 부트캠프 5기 김필진 카카오 메인페이지 클론코딩 #61
Open
sihyun92
wants to merge
20
commits into
KDT1-FE:main
Choose a base branch
from
sihyun92:KDT5_KimPilJin
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9f585dd - Browse repository at this point
Copy the full SHA 9f585ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba7b373 - Browse repository at this point
Copy the full SHA ba7b373View commit details -
Configuration menu - View commit details
-
Copy full SHA for e3901f7 - Browse repository at this point
Copy the full SHA e3901f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b94445 - Browse repository at this point
Copy the full SHA 5b94445View commit details
Commits on Apr 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c76973f - Browse repository at this point
Copy the full SHA c76973fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24a0b58 - Browse repository at this point
Copy the full SHA 24a0b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20c6e30 - Browse repository at this point
Copy the full SHA 20c6e30View commit details -
Fix leftContent.style.top in line 15
> onScrollFixedCard 함수 안에 leftContent.style.top의 값을 635px로 수정 > 각 로직에 대한 주석 작성
Configuration menu - View commit details
-
Copy full SHA for a5b6d9d - Browse repository at this point
Copy the full SHA a5b6d9dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 176d009 - Browse repository at this point
Copy the full SHA 176d009View commit details -
> 오른쪽 카드의 위치 position: absolute로 위치 재조정 > TODO: content-container의 크기 및 레이아웃 재조정 예정(width값이 1296px인데 1332px로 출력 -> flex 박스 gap 조정 예정)
Configuration menu - View commit details
-
Copy full SHA for 8df2a3c - Browse repository at this point
Copy the full SHA 8df2a3cView commit details
Commits on Apr 7, 2023
-
> content-container에 width 속성 추가 => 바깥으로 밀려나는 레이아웃 수정
Configuration menu - View commit details
-
Copy full SHA for 77e26d9 - Browse repository at this point
Copy the full SHA 77e26d9View commit details
Commits on Apr 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4e16039 - Browse repository at this point
Copy the full SHA 4e16039View commit details -
Configuration menu - View commit details
-
Copy full SHA for c61f004 - Browse repository at this point
Copy the full SHA c61f004View commit details -
Modify onScrollHeader and eventListener in header.js
> 이벤트 scroll에서 wheel로 변경 > onScrollHeader 함수 파라미터에 이벤트 객체 넣은 후, e.deltaY로 휠 이벤트 제어
Configuration menu - View commit details
-
Copy full SHA for 8592743 - Browse repository at this point
Copy the full SHA 8592743View commit details -
Add wheelUp event at the same time header visibility
> 휠업 시, 헤더가 나타나는 기능 구현
Configuration menu - View commit details
-
Copy full SHA for 965d89a - Browse repository at this point
Copy the full SHA 965d89aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc6f7a4 - Browse repository at this point
Copy the full SHA bc6f7a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e6f09b9 - Browse repository at this point
Copy the full SHA e6f09b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 656a9d1 - Browse repository at this point
Copy the full SHA 656a9d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33ac221 - Browse repository at this point
Copy the full SHA 33ac221View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3796ad8 - Browse repository at this point
Copy the full SHA 3796ad8View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.