KDT5_KimSeoungEun_recover commit #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamidlek
reviewed
Apr 9, 2023
There was a problem hiding this comment.
고생하셨습니다.
html, css 위주로 확인하였고
js는 스크롤 관련 쓰로틀 걸고 잘 하신 것 같습니다.
중복되는 부분은 코멘트 하지 않았습니다.
HTML
시멘틱 하게 잘 작성해 주신 것 같아요.
크게 문제되는 사항이 없었던 것 같습니다.
CSS
scss 잘 활용하여 주셨습니다.
BEM 방법론 적용은 요구 사항에 있었는데
크게 적용하지 않으신 것 같아요
css에서 활용 할 수있는 많은 부분을 활용해 주신 것 같습니다.
JS
지금 처럼 요소를 찾고 원하는 동작을 시도해 보시는 것으로
충분 할 것 같습니다. top으로 가는 버튼도 js로 빼서 작성을 완료해 보면
좋을 것 같습니다.
| <link | ||
| rel="stylesheet" | ||
| href="https://cdn.jsdelivr.net/npm/[email protected]/reset.min.css" | ||
| /> |
There was a problem hiding this comment.
적용하실 css 보다 reset css 를 먼저 적용하셔야 할 것 같아요.
같은 점수일 경우 나중에 부르는 스타일시트를 덮어 쓰게 됩니다.
| <!-- HEADER --> | ||
| <header> | ||
| <div class="inner"> | ||
| <div class="nav"> |
There was a problem hiding this comment.
네익게이션이면 nav 태그 사용해 주시면 좋을 것 같아요.
| </div> | ||
| <article class="center_image"> | ||
| <div class="box"> | ||
| <div class="image_odd" style="cursor: pointer"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
강사님 안녕하세요.5기 수강생 김성은이라고 합니다!
래퍼런스 사이트 : https://hkd-microbiome.com/ko/
클론 사이트 : https://kse-seong-eun.github.io/HKDmicrobiome__CloneCoding/