주하림 클론코딩 과제 #40
Open
주하림 클론코딩 과제 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanuuuuu
reviewed
Apr 15, 2023
chanuuuuu
reviewed
Apr 15, 2023
chanuuuuu
reviewed
Apr 15, 2023
| </header> | ||
| <div class="content"> | ||
| <div class="inner"> | ||
| <div class="main"> |
There was a problem hiding this comment.
원본의 태그는 div가 아닌 main 태그를 사용하였는데요. main 태그를 사용하지 않고 div를 사용한 이유가 있을까요?🤔
** main 태그를 사용하는 이유는 무엇일까요?
There was a problem hiding this comment.
원본 구성을 보지 않고 스스로 만들어서 습관적으로 div태그를 사용한 것 같아요. body 요소의 주 콘텐츠를 정의할때 main을 사용하는 것으로 알고 있습니다. 궁금해서 더 찾아봤는데, 문서에서 한번만 사용이 가능하며, article, aside, footer, header, nav 요소의 자손 요소가 되면 안된다고 합니다.
There was a problem hiding this comment.
HTML 리팩토링이나 다른 프로젝트를 진행할 때, 꼭 다양한 시맨틱 태그를 사용해보는 것을 추천드립니다!
chanuuuuu
reviewed
Apr 15, 2023
chanuuuuu
reviewed
Apr 15, 2023
chanuuuuu
reviewed
Apr 15, 2023
chanuuuuu
reviewed
Apr 15, 2023
dmswl2030
reviewed
Apr 24, 2023
DevYBecca
reviewed
Apr 24, 2023
| <h5>SUBJECT</h5> | ||
| <ul> | ||
| <li> | ||
| <a href="javascript:void(0)">TRAVEL</a> |
There was a problem hiding this comment.
우측 상단 메뉴 카테고리에 hover event가 발생하면 이미지가 바뀌는 효과를 한번 확인해봤습니다! 실제 사이트에서 css 속성으로 작업한 것이 아니라 html의 데이터 속성을 사용하여 background-image를 작업한 것 같더라구요! 저도 생소한 내용이라 서로 공유해보면 좋을 것 같은 포스팅들을 찾아봤습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
원본 사이트: https://readcereal.com/
과제 사이트: https://snazzy-panda-830a31.netlify.app/
멋진 사진이 가득한 잡지사 사이트를 클론코딩 했습니다.
HTML, CSS로만 구현했습니다.
아쉬운점