Add Basic CSS Color Parsing #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #24 +/- ##
=============================================
+ Coverage 42.70% 66.91% +24.20%
- Complexity 37 54 +17
=============================================
Files 16 27 +11
Lines 384 807 +423
Branches 52 66 +14
=============================================
+ Hits 164 540 +376
- Misses 197 238 +41
- Partials 23 29 +6
Continue to review full report at Codecov.
|
twyatt
approved these changes
Apr 2, 2021
Comment on lines
+5
to
+8
| private val RGB = """($HEX)($HEX)($HEX)""".toRegex(RegexOption.IGNORE_CASE) | ||
| private val RGBA = """($HEX)($HEX)($HEX)($HEX)""".toRegex(RegexOption.IGNORE_CASE) | ||
| private val RRGGBB = """($HEX{2})($HEX{2})($HEX{2})""".toRegex(RegexOption.IGNORE_CASE) | ||
| private val RRGGBBAA = """($HEX{2})($HEX{2})($HEX{2})($HEX{2})""".toRegex(RegexOption.IGNORE_CASE) |
There was a problem hiding this comment.
I suspect that regex approach is slower than processing by simple iteration.
But we can definitely postpone that optimization (and should benchmark to verify that regex is even slower).
Created #25 (super low priority though) to potentially address this later.
twyatt
reviewed
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, only parses color keywords and hex notation (
#rgb,#rgba,#rrggbb,#rrggbbaa). In the future we should includergb()function call syntax. As such, I'm considering this only a partial implementation of #22.Also wrote a few bonus tests since I was looking at the coverage report and they seemed fast.