Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an Android Lint check that ensures the correct Log class is used #83

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

eygraber
Copy link
Contributor

@twyatt twyatt added the minor Changes that should bump the MINOR version number label Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.16%. Comparing base (84a3254) to head (37aabd8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #83   +/-   ##
=========================================
  Coverage     80.16%   80.16%           
  Complexity      117      117           
=========================================
  Files            15       15           
  Lines           247      247           
  Branches         16       16           
=========================================
  Hits            198      198           
  Misses           46       46           
  Partials          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@twyatt twyatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this is awesome! Thanks, @eygraber!
Just have a few minor questions/comments.

gradle/libs.versions.toml Outdated Show resolved Hide resolved
gradle/libs.versions.toml Outdated Show resolved Hide resolved
@eygraber eygraber requested a review from twyatt November 19, 2024 18:29
@twyatt
Copy link
Member

twyatt commented Nov 19, 2024

Thanks for the contribution, @eygraber!

@twyatt twyatt merged commit af56152 into JuulLabs:main Nov 19, 2024
2 checks passed
@twyatt

This comment was marked as outdated.

@twyatt
Copy link
Member

twyatt commented Nov 20, 2024

Should be available in 0.4.1 release.

@eygraber
Copy link
Contributor Author

Awesome, thank you!

@eygraber eygraber deleted the lint-check branch November 20, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Changes that should bump the MINOR version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants