Development #102
Merged
Development #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating repo to be in sync with Justin's
� Conflicts: � panel_test_app/app.py
…age. Going to work on features and refactoring next.
…ixed the panel deployment to allow pythonic combinations of html and other panel objects in the deployment.
…objects covering: curve fills, curves, tracks, and well logs with multiple tracks. I have a plan to add "well section" type template that handles drawing multiple well logs.
…ch and trying to make it easier to extend/handle modified templates.
…e setting up a test package so I can bundle it for the browser deployment at the end. I've got log loading propagating through the modules in tests ok. The next part is breaking down and distributing the D3 draw calls throughout the modules.
…r it. Switching gears now for a break towards getting panel working more dynamically with wellioviz.
…having trouble passing the file data to the javascript side on a callback.
|
Wow, lots of good stuff in here. I've only looked at diff files so far. Will try to clone locally and run some checks Sunday or Monday, then merge into the master branch. Can you talk a bit on how you envision people adding/sharing/changing things related to the log_curve_templates? I was thinking of doing at some of the styles via JSONs to make it easier to save, edit, and share styles. Is that something you could merge into your JS function based approach? |
|
Okay, had more time to look at the files. We're actually already aligned and I didn't realize earlier. |
JustinGOSSES
approved these changes
Jun 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
#99
#30
#11
#22
Motivation and Context
This was done as a part of the Transform 2020 hackathon and the goal is to keep pushing this towards being a powerful, professional, and open source well log visualization option for both python and javascript web application and notebook deployments.
Types of changes
Checklist:
^^ ** The WIP code stills needs work to align the style as well as architecture discussion and alignment, but it is not the primary motivation for this pull request. These could be edited out by Justin prior to the merge if that is preferred and I can re-submit those changes when they are ready to roll out.