Merge pull request #51 from nathandaly/getpostcodes-patch-1

Fixing Array to string conversion warning on getPoscodes method
JustSteveKing · Sep 12, 2023 · 1d8158e · 1d8158e
2 parents 72d344e + d74267f
commit 1d8158e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/Service/PostcodeService.php b/src/Service/PostcodeService.php
@@ -89,12 +89,14 @@ public function getPostcode(string $postcode): object
      */
     public function getPostcodes(array $postcodes, array $filter = []): Collection
     {
+        $queryParams = '';
+
         if (!empty($filter)) {
-            $filter = Query::build(['filter' => implode(',', $filter)]);
+            $queryParams = Query::build(['filter' => implode(',', $filter)]);
         }
 
         return collect($this->getResponse(
-            'postcodes?' . $filter,
+            'postcodes?' . $queryParams,
             'POST',
             ['postcodes' => array_values($postcodes)]
         ))->map(function ($item) {