Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix project order for 1.9 #106

Merged
merged 2 commits into from
May 17, 2023
Merged

Fix project order for 1.9 #106

merged 2 commits into from
May 17, 2023

Conversation

gdalle
Copy link
Contributor

@gdalle gdalle commented Apr 24, 2023

Solves #105

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #106 (828e278) into master (57492cd) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   75.29%   75.00%   -0.30%     
==========================================
  Files          11       11              
  Lines         676      676              
==========================================
- Hits          509      507       -2     
- Misses        167      169       +2     
Flag Coverage Δ
unittests 75.00% <ø> (-0.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils.jl 93.22% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Krastanov
Copy link

@oxinabox , @DilumAluthge -- pardon the cold ping, but you are the most senior active folks in this organization. Any chance you can merge this and make a new release? Aqua checks are failing on pkgextensions

@gdalle
Copy link
Contributor Author

gdalle commented May 17, 2023

Not sure how to fix code style though, sorry

src/utils.jl Outdated Show resolved Hide resolved
@DilumAluthge DilumAluthge merged commit 7be3744 into JuliaTesting:master May 17, 2023
@gdalle gdalle deleted the patch-1 branch May 17, 2023 05:27
@gdalle
Copy link
Contributor Author

gdalle commented May 17, 2023

thanks!

@jishnub
Copy link
Contributor

jishnub commented May 17, 2023

This should perhaps be backported to v0.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants