-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecation warnings #70
Conversation
Changes Unknown when pulling 1955e5e on KristofferC:kc/customOptions into ** on sisl:master**. |
Changes Unknown when pulling e1a8f7e on KristofferC:kc/customOptions into ** on sisl:master**. |
1 similar comment
Changes Unknown when pulling e1a8f7e on KristofferC:kc/customOptions into ** on sisl:master**. |
Hmm, I wonder if this is the best interface. Sometimes you don't want to give a key value pair but simply a string (like |
It could perhaps also be nice to be able to give a |
Thank you for writing this!
There are some differences - "black" for instance can be passed in as a value without having an associated key name. Definitely want to hear what @mykelk has to say. |
Arbitrary options can be passed to an axis through the It might feel a little strange passing these options in as a string, but I put that support in initially so that we can do anything the latex package supports. One thing that I was thinking of doing was allowing I'd like to know your thoughts. And thank you for your contribution! We'll want to settle these question before merging. (And thanks for the fixes for 0.6.) |
I didn't think about passing it through |
Sounds good. It would be great to get those deprecation commits in. Thanks! |
e1a8f7e
to
4eecb93
Compare
I've changed this to only fix deprecation warnings in code and notebook |
Changes Unknown when pulling 4eecb93 on KristofferC:kc/customOptions into ** on sisl:master**. |
Btw further discussion should be on #69 |
@tawheeler I'm okay with merging if you are. Go for it if you're good with it. |
Thank you! |
Wrapping ALL of PGFPlots is likely far away, this provides an escape hatch to inject arbitrary options into an axis:
This PR also fixes the deprecation warnings for 0.6.