Remove type restrictions that prevent PCA on Float32 and GPU arrays #235
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, parts of the PCA calculation force concrete
Vector
andMatrix
types. This prevents bothfit(::PCA, x::Matrix{Float32})
orfit(::PCA, x::CuArray)
, both of which can be significantly faster for large arrays (besides not having to offload or convert these large Float32/CUDA arrays); a comparison is below.This PR removes these concrete type annotations. It also revises
choose_pcadim()
to avoid scalar indexing, but has (?) to calculate the cumulative sum over the full explained variance (this would perform slightly worse than the current implementation, which breaks the sum after the optimal dimensionality is found).