Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force return type on pwrss and logdet to provide stable type inference on objective #771

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Jun 20, 2024

Closes #770

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@dmbates dmbates requested a review from palday June 20, 2024 21:59
@dmbates
Copy link
Collaborator Author

dmbates commented Jun 20, 2024

I can verify that this saves several microseconds when fitting a model.

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (3549258) to head (efdc3c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          34       34           
  Lines        3356     3356           
=======================================
  Hits         3253     3253           
  Misses        103      103           
Flag Coverage Δ
current 96.87% <100.00%> (ø)
minimum 96.83% <100.00%> (ø)
nightly 96.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday merged commit 39dd384 into main Jun 20, 2024
12 checks passed
@palday palday deleted the db/typeinference branch June 20, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type inference fails for logdet(m) and pwrss(m) and, hence for objective(m)
2 participants