Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delegate as many GLMM properties as possible to internal LMM #767

Merged
merged 2 commits into from
May 15, 2024

Conversation

palday
Copy link
Member

@palday palday commented May 15, 2024

@dmbates is there a giant footgun I'm missing by swapping to "delegate by default" instead of "delegate by explicit list"?

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@palday palday requested a review from dmbates May 15, 2024 17:52
Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (c4beee9) to head (484d33b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   96.93%   96.93%   -0.01%     
==========================================
  Files          34       34              
  Lines        3358     3356       -2     
==========================================
- Hits         3255     3253       -2     
  Misses        103      103              
Flag Coverage Δ
current 96.87% <100.00%> (-0.01%) ⬇️
minimum 96.77% <100.00%> (-0.07%) ⬇️
nightly 96.43% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. The only footgun I can imagine is if there is a property of an LMM that wouldn't make sense for a GLMM, like σ, but all of those seem to be handled in earlier elseif blocks.

@palday palday merged commit 84a61c2 into main May 15, 2024
12 checks passed
@palday palday deleted the pa/glmm_delegation branch May 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants