-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for rank deficiency in bootstrap #755
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #755 +/- ##
==========================================
+ Coverage 96.33% 96.45% +0.11%
==========================================
Files 34 34
Lines 3356 3354 -2
==========================================
+ Hits 3233 3235 +2
+ Misses 123 119 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ixedModels.jl into pa/rank_deficient_bootstrap
Co-authored-by: Alex Arslan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that this works in the case that motivated #754 and that
dropped_idx = findall((coef(model) .=== -0.0) .& isnan.(stderror(model)))
dropped_coefs = coefnames(model)[dropped_idx]
all(nt -> !(nt.coefname in dropped_coefs) || nt.β !== -0.0, boot.β)
is true
. (Extending the added test to the case of multiple dropped columns)
closes #754
Did behavior change? Did you add need features? If so, please update NEWS.md
docs/NEWS-update.jl
to update the cross-references.Should we release your changes right away? If so, bump the version: