Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coefnames(::ReMat) #709

Merged
merged 4 commits into from
Aug 20, 2023
Merged

Add coefnames(::ReMat) #709

merged 4 commits into from
Aug 20, 2023

Conversation

palday
Copy link
Member

@palday palday commented Aug 20, 2023

I've used this a few times when working on plotting.

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@palday palday requested a review from dmbates August 20, 2023 15:12
@codecov
Copy link

codecov bot commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (66ec87d) 95.83% compared to head (5d2426a) 95.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          35       35           
  Lines        3266     3266           
=======================================
  Hits         3130     3130           
  Misses        136      136           
Flag Coverage Δ
current 95.83% <100.00%> (+<0.01%) ⬆️
minimum 95.73% <100.00%> (+<0.01%) ⬆️
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/linearmixedmodel.jl 95.00% <100.00%> (ø)
src/remat.jl 97.18% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -599,7 +599,7 @@ fixef(m::LinearMixedModel{T}) where {T} = fixef!(Vector{T}(undef, m.feterm.rank)

Return a (permuted and truncated in the rank-deficient case) vector of coefficient names.
"""
function fixefnames(m::LinearMixedModel{T}) where {T}
function fixefnames(m::LinearMixedModel)
Xtrm = m.feterm
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@palday palday merged commit df203bc into main Aug 20, 2023
8 of 9 checks passed
@palday palday deleted the pa/re_coefnames branch August 20, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants