Add generic matmatmul for inplace sparse x sparse #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 85.00% 84.58% -0.42%
==========================================
Files 12 12
Lines 8967 9120 +153
==========================================
+ Hits 7622 7714 +92
- Misses 1345 1406 +61 ☔ View full report in Codecov by Sentry. |
|
We should merge if ready - the windows issue is separate. |
|
can you point to commit + lines of the old LinearAlgebra code this is copied from? |
|
It's the one you found here: JuliaLang/julia#52429 (comment), i.e., JuliaLang/julia@0cf2bf1. It's in matmul.jl, lines 786ff. |
|
Shall we merge this? I believe there is room for further improvement by providing specialized |
|
Agree - we should merge as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes JuliaLang/julia#52429.
I have no idea which branches are really used and whether this can be further reduced, especially in favor of compile time, which was a big issue over at LinearAlgebra.jl. Currently, this is just a copy-paste from the old LinAlg code.
@dmbates @palday