test: relax allocated tests #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several of these are failing being slightly over the threshold on some CI runs. Relax all the thresholds, since the intent is to make sure allocations are completely dynamic, not to prohibit them entirely.
|
Should we bump SparseArrays on master to pull this in? |
|
eventually yes |
|
it can be done here https://github.com/JuliaLang/BumpStdlibs.jl/actions/workflows/BumpStdlibs.yml |
|
Yeah, my question was whether this was urgent and if we should do it right away. |
|
it is causing a few CI to fail, but not the most frequent issue right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of these are failing being slightly over the threshold on some CI runs. Relax all the thresholds, since the intent is to make sure allocations are completely dynamic, not to prohibit them entirely.
C.f. https://buildkite.com/julialang/julia-master/builds/29821#018bab25-9f95-4abd-aabf-6eaa8c05859e for example