Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for Julia v1.10 #439

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Backports for Julia v1.10 #439

merged 7 commits into from
Oct 11, 2023

Conversation

dkarrasch
Copy link
Member

@dkarrasch
Copy link
Member Author

@vtjnash Could you please review your recent cat-related commits and push those that are suitable for backport here?

Ensures that Union{} is not part of the output possibilities after type-piracy of Base.cat methods.

Refs JuliaLang/julia#50550

(cherry picked from commit c402d09)
This little gadget creates a closure over Type{T} instead of DataType.

Fix JuliaLang/julia#50623

(cherry picked from commit 68afc6e)
The generic `cat` does more shape analysis, that typed_cat does not
always do (before either may then dispatch to _cat_t), so we can make
this faster by calling it instead.

Secondly, we can make `issparse` non-recursive once it hits a base case
where all trailing elements are the same. This makes it much better at
handling large splat, since we do not need to check each recursively
smaller type down to the base case using generic code, and just generate
one const method specialized on the full length instead.

Fix JuliaLang/julia#51011

(cherry picked from commit 4e6776a)
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-1.10@026e6a6). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             release-1.10     #439   +/-   ##
===============================================
  Coverage                ?   93.19%           
===============================================
  Files                   ?       12           
  Lines                   ?     7667           
  Branches                ?        0           
===============================================
  Hits                    ?     7145           
  Misses                  ?      522           
  Partials                ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jishnub
Copy link
Contributor

jishnub commented Sep 14, 2023

Can #423 be backported?

* Respect IOContext in printing column indices

* Add docstring to ColumnIndices
@ViralBShah
Copy link
Member

Do we want to try to get these into Julia 1.10?

@dkarrasch
Copy link
Member Author

Yes, definitely. We could merge now and then bump on Julia's release branch.

@dkarrasch
Copy link
Member Author

In fact, how about backporting the docs commit? I think the changes there were (at the end) minimal and not version-dependent.

* Adapt to Documenter v1
@dkarrasch dkarrasch merged commit d8aae6d into release-1.10 Oct 11, 2023
8 checks passed
@dkarrasch dkarrasch deleted the backports-release-1.10 branch October 11, 2023 17:02
@ViralBShah
Copy link
Member

One backport we should do is SuiteSparse 7.2.1. The current version on 1.10 uses @Wimmerer 's branch of SuiteSparse, but all that has been upstreamed in an official release in 7.2.1, which is making its way through Yggdrasil etc.

@dkarrasch dkarrasch restored the backports-release-1.10 branch October 19, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants