Fixes for self-installed MKL from intel oneAPI #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
j-fu
commented
Feb 15, 2024
j-fu
commented
- introduces Pardiso.mkl_is_available() for use in runtests.jl
- test load mkl in init (like pardiso)
- some link updates, hint at LD_LIBRARY_PATH
* introduces Pardiso.mkl_is_available() for use in runtests.jl * test load mkl in __init__ (like pardiso) * some link updates, hint at LD_LIBRARY_PATH
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #99 +/- ##
==========================================
+ Coverage 39.68% 40.67% +0.99%
==========================================
Files 4 4
Lines 378 386 +8
==========================================
+ Hits 150 157 +7
- Misses 228 229 +1 ☔ View full report in Codecov by Sentry. |
KristofferC
reviewed
Feb 16, 2024
| * Run `Pardiso.show_build_log()` to see the build log for additional | ||
| information. | ||
| * Note that the `MKLROOT` environment variable must be set whenever using the library. | ||
| * Note that the `MKLROOT` environment variable must be set, and `LD_LIBRARY_PATH` must contain `$MKLROOT/lib` |
There was a problem hiding this comment.
Is this true? I don't think I have had to explicitly set this before.
There was a problem hiding this comment.
The advise by intel is to run
source /opt/intel/oneapi/setvars.sh
This sets MKLROOT and adds the lib directory to the LD_LIBRARY_PATH . I accidently run with only MKLROOT set, and libmkl_rt was not found as a consequence.
KristofferC
reviewed
Feb 16, 2024
KristofferC
reviewed
Feb 16, 2024
KristofferC
reviewed
Feb 16, 2024
KristofferC
reviewed
Feb 16, 2024
Co-authored-by: Kristoffer Carlsson <[email protected]>
* make error msg less specific if it is not available.
* set to true in __init__ if libmkl_rt cannot be loaded * checked by mkl_is_available(), so MKLPardisoSolver() cannot be instantiated if load failed
|
IMHO ready to merge. |
|
Would first merge this and then retry the registry attempt at e62b47a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.