Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't change newline on Windows #59

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Don't change newline on Windows #59

merged 1 commit into from
Jul 4, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Jul 4, 2024

This PR ensures the same bytes are written out on all systems. This is especially useful on Windows when using WSL, where files written in Windows must be read in Linux.

I also added a .gitattributes file to prevent GitHub Windows CI from changing the file endings: https://code.visualstudio.com/docs/devcontainers/tips-and-tricks#_resolving-git-line-ending-issues-in-containers-resulting-in-many-modified-files

@tkonolige
Copy link
Collaborator

I'm having trouble finding any documentation on if matrix market files use \r\n on windows. The best I've found is scipy's implementation here: https://github.com/scipy/scipy/blob/v1.14.0/scipy/io/_fast_matrix_market/fast_matrix_market/include/fast_matrix_market/fast_matrix_market.hpp#L33. They just use \n everywhere, so I'm fine following their example.

@tkonolige tkonolige merged commit 0637e56 into JuliaSparse:master Jul 4, 2024
12 of 13 checks passed
@nhz2 nhz2 deleted the Don't-change-newline-on-Windows branch July 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants