-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading streaming from online .mtx or .mtx.gz files #54
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #54 +/- ##
==========================================
+ Coverage 92.20% 96.20% +3.99%
==========================================
Files 4 5 +1
Lines 154 237 +83
==========================================
+ Hits 142 228 +86
+ Misses 12 9 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Could you explain what you are trying to do with this PR. I'm not sure how I understand how it is related to reading from streams. It seems like having |
Sorry for not explain this clearly. To support streaming, we not only have to support the interface like |
Doesn't the IO interface support streaming? The use case here seems to be resuming downloads but that seems like a really niche use case. Do you have an example of how this is used (like with a library that resumes downloads)? Overall I think added complexity to the code is not worth it. |
Would I put the example to README? Or other place? I think the code complexity would stop at this PR. It is sufficient complex. |
Resolved #42