Support streaming and add new API #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #50 +/- ##
===========================================
+ Coverage 0.00% 79.67% +79.67%
===========================================
Files 1 8 +7
Lines 93 187 +94
===========================================
+ Hits 0 149 +149
+ Misses 93 38 -55
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tkonolige
requested changes
Feb 2, 2023
There was a problem hiding this comment.
Hi @yuehhua thanks for the PR! It seems like you are doing a lot of things:
- Splitting the main file into multiple files
- Supporting gziped files
- Moving
readinfofrom a flag to separate function - A large refactoring of the parsing code
(And maybe I'm missing some more?)
Could you split these changes into separate PRs so that they are easier to review and discuss.
|
I have separated 1 and 3 into individual PR. The rest features would follow after PR merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #42
There is new exported API
readinfoseparated frommmreadwith argumentinfoonly=true.