Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch feature mountain tracker to FolderDict #1008

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dehann
Copy link
Member

@dehann dehann commented Feb 18, 2024

No description provided.

)
# start with everything from fMb
# FIXME, this deepcopy is going to explode the memory consumption
rM = deepcopy(fMb)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI @Affie , this may be part of the memory use issue. This PR will help some, and we can refactor more in a follow-up PR.

@dehann dehann requested a review from Affie February 18, 2024 01:11
@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (209e9f0) 27.63% compared to head (586aca9) 27.62%.

Files Patch % Lines
ext/Images/FeatureMountain.jl 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1008      +/-   ##
==========================================
- Coverage   27.63%   27.62%   -0.02%     
==========================================
  Files          54       54              
  Lines        2580     2581       +1     
==========================================
  Hits          713      713              
- Misses       1867     1868       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dehann dehann marked this pull request as ready for review February 19, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants