Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: EntropyScaling v0.1.0 #118174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Oct 27, 2024

Copy link
Contributor

github-actions bot commented Oct 27, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines are all met! ✅

Your new package registration met all of the guidelines for auto-merging and is scheduled to be merged when the mandatory waiting period (3 days) has elapsed.

3. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

UUID: 36a13073-9e6e-4b19-b12b-cb530e79ee8e
Repo: https://github.com/se-schmitt/EntropyScaling.jl.git
Tree: eb143f5ac06ca070ec8dccb322f834ff32636a7c

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-entropyscaling-36a13073-v0.1.0-94ccaef1f4 branch from bc8692b to c12168d Compare October 27, 2024 22:48
JuliaRegistrator referenced this pull request in se-schmitt/EntropyScaling.jl Oct 27, 2024
@goerz
Copy link
Member

goerz commented Oct 30, 2024

Congratulations on the new package!

I just wanted to check with you that you think the name isn't too general, since the README says

This is an implementation of the entropy scaling framework introduced in [paper]

Are there other widely used approaches to entropy scaling that are not covered by this package? If there were, and you're not planning to support those in this package, maybe EntropyScaling isn't an ideal name, and you'd want to add a prefix to disambiguate it.

I'm not a domain expert on this, so I'll leave this entirely to your judgement. I also realize I'm a bit late in the review period, so I'm just making this comment temporarily blocking to give you a chance to review it before the automerge.

If you decide you want to go forward with the current name, I'll be happy to unblock

@JuliaTagBot JuliaTagBot added the AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoMerge: last run blocked by comment PR blocked by one or more comments lacking the string [noblock]. new package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants