Add shuffle implementation to preserve stability
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
|
Alright, CI passing here! It is failing on main on nightly as discussed in #10 |
Merged
rfourquet
reviewed
Dec 9, 2023
| @@ -132,5 +139,20 @@ for T in Base.BitInteger_types | |||
| SamplerRangeFast(r) | |||
| end | |||
|
|
|||
| # https://github.com/JuliaRandom/StableRNGs.jl/issues/10 | |||
| Random.shuffle(r::StableRNG, a::AbstractArray) = Random.shuffle!(r, Base.copymutable(a)) | |||
There was a problem hiding this comment.
I'm not sure, but I would prefer to keep it, in case it becomes necessary. It doesn't seem harmful either.
|
@rfourquet would this deserve a new release? |
|
It got one: JuliaRegistries/General#96886 |
|
My bad, I just checked out the repo tags and the last one is from 2020. Probably because TagBot is not installed? |
|
Thanks for noticing @gdalle, I've fixed this and made a PR to add TagBot (#21). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #10