Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export remotecall_eval #23

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Export remotecall_eval #23

merged 2 commits into from
Jan 24, 2025

Conversation

JamesWrigley
Copy link
Collaborator

Backported from Distributed (CC @nickrobinson251): JuliaLang/Distributed.jl#123

This is a fairly straight-forward change so if there's no objections I'll merge it later today.

@JamesWrigley JamesWrigley self-assigned this Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.17%. Comparing base (97b7f4a) to head (6ac243d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #23   +/-   ##
=======================================
  Coverage   88.17%   88.17%           
=======================================
  Files          11       11           
  Lines        2080     2080           
=======================================
  Hits         1834     1834           
  Misses        246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamesWrigley
Copy link
Collaborator Author

I'm guessing that the failure on 1.9 is due to something else binding to the hardcoded worker bind port in the SSHManager tests, should be fixed in 6ac243d.

@JamesWrigley JamesWrigley merged commit a7dabfc into master Jan 24, 2025
14 checks passed
@JamesWrigley JamesWrigley deleted the remotecall-eval branch January 24, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants