[libzenohc] Update to 1.0.0 #9693
Open
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giordano
reviewed
Oct 27, 2024
There was a problem hiding this comment.
You don't need to (or, really, shouldn't) use the wizard to update an existing recipe: https://docs.binarybuilder.org/stable/#Manually-create-or-edit-build_tarballs.jl
L/libzenohc/build_tarballs.jl
Outdated
| """ | ||
|
|
||
| # These are the platforms we will build for by default, unless further | ||
| # platforms are passed in on the command line | ||
| platforms = [ | ||
| Platform("aarch64", "macos"; ), |
There was a problem hiding this comment.
This changed the order of the platforms, which (a) makes review harder than necessary and (b) breaks git blame.
There was a problem hiding this comment.
Thanks for the feedback, what's the preferred order / sorting? Unfortunately I couldn't get it to build on FreeBSD anymore. I tried all platforms and powerpc64le now seems to work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a new build recipe I built using the BinaryBuilder.jl wizard:
@staticfloat please review and merge.