Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is update to ChemicalSpecies.
info
field toname
field and make it represent 4 charactersatomic_name
to access the new name field if given, else returnatomic_symbol
The idea with
atomic_name
is to represent PDB file format defines atom name columns (13-16). Whileelement_symbol
represents element columns (77-78)element_symbol
always gives the symbol of the elementatomic_symbol
adds isotope information if givenatomic_name
defaults toatomic_symbol
, but overwrites it withatomic_name
if species has that information.This works now
Comparisons
The basic idea is that if no isotope or name information is given, then that ChemicalSpecies works as a general atom with that atomic number.
atomic_name
on the other hand is used to distinguish atoms with same type of atoms.So basically, you can create a potential using
ChemicalSpecies(:C)
. Users can then mark their systems with isotopes or atomic names, for some additional information and the potential that uses "the general carbon" works with them.masses
@mfherbst @cortner