Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pointless norm on vector fibers #209

Merged
merged 4 commits into from
Oct 24, 2024
Merged

Pointless norm on vector fibers #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6603c8
Pointless norm on vector fibers
mateuszbaran Oct 21, 2024
886e004
Remove the variant with `p`
mateuszbaran Oct 23, 2024
3ca4d56
improve NEWS
mateuszbaran Oct 23, 2024
8b9447a
Update NEWS.md
mateuszbaran Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [0.15.20] 24/10/2024

### Changed

* `norm` function on `VectorSpaceFiber` (such as `TangentSpace`) now needs to be called without the point. The passed point was already ignored before.

## [0.15.19] 20/10/2024

### Changed
Expand Down
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ManifoldsBase"
uuid = "3362f125-f0bb-47a3-aa74-596ffd7ef2fb"
authors = ["Seth Axen <[email protected]>", "Mateusz Baran <[email protected]>", "Ronny Bergmann <[email protected]>", "Antoine Levitt <[email protected]>"]
version = "0.15.19"
version = "0.15.20"

[deps]
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
Expand Down
4 changes: 3 additions & 1 deletion src/VectorFiber.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,6 @@ Alias for a [`Fiber`](@ref) when the fiber is a vector space.
const VectorSpaceFiber{𝔽,M,TSpaceType} =
Fiber{𝔽,TSpaceType,M} where {𝔽,M<:AbstractManifold{𝔽},TSpaceType<:VectorSpaceType}

LinearAlgebra.norm(M::VectorSpaceFiber, p, X) = norm(M.manifold, M.point, X)
LinearAlgebra.norm(M::VectorSpaceFiber, X) = norm(M.manifold, M.point, X)
# disambiguation
LinearAlgebra.norm(M::VectorSpaceFiber, X::Real) = norm(M.manifold, M.point, X)
10 changes: 9 additions & 1 deletion test/fibers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ using ManifoldsBaseTestUtils
@test isapprox(t_p, log(t_p, X, Y), [0.0, 2.0, -2.0])
@test isapprox(t_p, X, log(t_p, X, Y), [0.0, 2.0, -2.0])
@test inner(t_p, X, X, X) ≈ 1.0
@test norm(t_p, X, X) ≈ 1.0
@test norm(t_p, X) ≈ 1.0
@test norm(t_p, X) ≈ 1.0
@test parallel_transport_to(t_p, X, Y, X) ≈ Y
@test vector_transport_to(t_p, X, Y, X) ≈ Y
@test vector_transport_to(t_p, X, Y, X, ProjectionTransport()) ≈ Y
Expand Down Expand Up @@ -78,6 +79,13 @@ using ManifoldsBaseTestUtils
get_vector!(t_p, Z1, p, X1c, basis)
@test isapprox(Z1, X)
end

@testset "scalar fiber" begin
Ms = DefaultManifold()
p = 1.0
t_p = TangentSpace(Ms, p)
@test norm(t_p, 2.0) == 2.0
end
end

@testset "Weingarten Map" begin
Expand Down
Loading