Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compute the number of dimensions N in build_solution #28

Closed
wants to merge 2 commits into from
Closed

Compute the number of dimensions N in build_solution #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87d9053
Compute the number of dimensions N
olivierverdier Jun 30, 2024
e442535
Update compat to SciMLBase 2.40.0
olivierverdier Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ ManifoldsBase = "0.15"
Markdown = "1.6"
OrdinaryDiffEq = "6"
RecursiveArrayTools = "2, 3"
SciMLBase = "1.0, 2"
SciMLBase = "2.40.0"
julia = "1.6"

[extras]
Expand Down
3 changes: 2 additions & 1 deletion src/problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,8 @@ function build_solution(
interp.cache,
prob.manifold,
)
return ODESolution{T,1}(
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless your solutions were scalar valued this was never correct.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ndims is required to be defined to use ODESolution then we can't use it here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it looks like if we can't use ODESolution, SciMLBase has almost nothing that can be used in ManifoldDiffEq.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, whether maybe the solution in this PR is enough, but I also could not find what N actually refers to by looking at either https://docs.sciml.ai/DiffEqDocs/stable/types/ode_types/#SciMLBase.ODESolution or (had to look for that manually since it was not linked) https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#SciMLBase.AbstractODESolution or (same manual search) https://docs.sciml.ai/SciMLBase/stable/interfaces/Solutions/#SciMLBase.AbstractTimeseriesSolution ... (and then I got a bit tired).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any solution that uses ndims is at best a workaround since ndims is not a valid concept for points on a manifold or tangent vectors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do agree.

N = ndims(eltype(u)) + 1
return ODESolution{T,N}(
u,
nothing,
nothing,
Expand Down
Loading